fix(spec): defineStack cross-reference validation reaches inline page-element actions (#6889) - #7392
Merged
Merged
Conversation
…-element actions (#6889) `validateCrossReferences` iterated `config.actions` only, so an action authored inline on a page element (`element:button` -> `properties.action`) was never cross-referenced. Measured on main: a dangling inline `type: 'modal'` target built clean and failed only when a user clicked, while the identical target on a registered action was a build error. Page `regions[].components[]`, `slots.*` and nested container children are now walked, and every inline action found gets the SAME two target checks as a registered one -- same rule, same message tail, same size gates. The `flow` arm rides the same traversal. The modal arm mirrors the registered rule rather than also accepting an object name, per the maintainer ruling on #6739 (2026-08-09): a `type: 'modal'` target names a PAGE, only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PiRUoQkTSBBmpyXBY3cVn2
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 106 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
⛔ 7 release-owned page(s) also reference the affected code. These are read-only:
|
github-actions
Bot
added
documentation
os-zhuang
marked this pull request as ready for review
August 10, 2026 09:33
Contributor
⛔ merge queue 构建失败 — 先分诊，再决定要不要重排队列构建 31375385610 红了。队列跑的是全量套件（PR 侧 CI 只跑 affected 子集）， 失败的 job（日志抽取，best effort）：
历史信号：
分诊清单：
Generated by Claude Code · merge-queue-triage workflow (#4859) |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6889
defineStack's action cross-reference walk iteratedconfig.actions— the registeredaction list — only. An action authored inline on a page element (
element:button→properties.action, anInlineActionSchema) never enters that list, so nocross-reference check ever visited one. A dangling
type: 'modal'target built clean,shipped, and failed only when a user clicked it.
This walks page/region/component trees for inline actions and subjects them to the same
checks as registered ones — same rule, same message tail, one more traversal. The
flowarm rides the same traversal.
Probe — the card's five stacks, before and after
Re-measured on
mainfirst (line numbers had drifted; the walk was re-anchored bycontent). Rows F/G add the
flowhalf the card names. Same object (probe_task) and page(
probe_home) in every stack; onedefineStackcall each.Rows added while building the traversal, all measured:
childrenslotsrather thanregionsname)tospellingform→ object edit viewurl/api/script/navigationBefore-state excerpt, on
main:After:
Contract anchor — #6739's ruling fixes the modal arm
Row D is the A/D split, and its verdict is not this card's to invent. The maintainer ruled
it on #6739 on 2026-08-09 (comment),
quoted verbatim:
The same ruling sequenced this card explicitly:
The showcase fix merged as PR #7237, so the corpus is clean and the card proceeds. Because
the ruling settled the contract, the inline modal arm mirrors the registered rule
exactly rather than also accepting an object name — no residual D/A question is escalated.
objectNamehas no inline counterpart to check:InlineActionSchemadoes not pick thatkey, so an inline action cannot bind an object by name.
Corpus census — 0 shipped stacks newly refuse
Acceptance-face narrowing, so every
defineStackcorpus was censused — behaviourally, bybuilding it, not by grep alone:
examples/app-showcase(16 files / 164 tests)type: 'form'since #6739examples/app-crm(2 / 27),examples/app-todo(3 / 105)packages/qa/dogfood(86 / 534, 17defineStacksites)packages/spec(363 / 9488)packages/lint(70 / 1852),packages/cli(107 / 1155)packages/runtime(119 / 1870)cloudtenant pages (5 inline buttons)type: 'url'The only inline action in the reference corpus is the showcase home CTA
(
examples/app-showcase/src/ui/pages/index.ts),type: 'form'+target: 'showcase_task.edit'. Neitherformnorurlis cross-referenced, so zero legitimateshipped stacks break. A vacuity guard pins that shape in the new test file, so the census
cannot go stale silently.
Reverse verification — predicted in writing, then run
Predicted before running: removing the traversal must turn exactly the rejection-class
tests red — they assert a refusal old code never produces, so they fail with
[]— whileevery accept-class test stays green. The direction cannot invert here, because the change
only adds refusals; there is no shape that was rejected before and is accepted now.
Measured with
git checkout origin/main -- packages/spec/src/stack.zod.ts(nevergit stash— shared stack):The 10 failures are exactly the 10 rejection-class cases enumerated in the prediction, and
the 10 accept-class cases stayed green. (One honest correction: the written prediction
summarised the set as "9 red" while the enumerated list held 10 — the set was predicted
exactly, the arithmetic summary was off by one.) Restoring the file returns 20/20 green.
Tests
packages/spec/src/stack-inline-action-crossref.test.ts— 20 cases. Rejection cases pinfull message text with
toEqual, nottoThrow: a bare throw assertion cannot separate"refused for the right reason" from "refused because the fixture is broken", and each
rejection fixture differs from an accepted twin by exactly one string. Covered: both target
arms, the A/D-split parity table, the flow size gate, container nesting,
slots, anonymousactions, the legacy
tospelling, a nodeInlineActionSchemacannot parse, multipleoffenders on one page, and the five action types that must stay untouched.
Implementation note
Candidates are normalized by parsing with
InlineActionSchemarather than readkey-by-key: that schema's preprocess is what canonicalizes the legacy
tospelling ontotarget, and page-componentpropertiesarez.record(z.string(), z.unknown()), so a rawnode has not been through it. Reading
action.target ?? action.toin the validator would bea second, hand-mirrored copy of the producer's normalization — the consumer-side leniency
Prime Directive #12 rejects. When that parse fails the node is still checked from its raw
type/targetstrings, so a dangling reference cannot hide behind an unrelated defect;the legacy spelling is deliberately not read there, since canonicalization stays the
schema's job.
The traversal recurses into any array under
propertieswhose entries are component-shaped(an object with a string
type), which reaches every container spelling —children, acard's
footer— without this walk enumerating them.Gates
pnpm lint(ESLint) exit 0 ·check:nul-bytesOK (6741 files) ·check:stack-collection-maps·
check:spec-parsed-alias·check:doc-authoring·check:docs-audit-scope·check:adr-anchors·check:quick-reference-counts·check:role-word·check:changeset-gate-self-tests·check:release-notes·check:engine-double-contract·check:error-code-casing·check:route-envelope— all OK.pnpm --filter @objectstack/spec typecheckclean.No gate demanded a docs or ADR edit;
content/docs/anddocs/adr/**are untouched.Changeset:
minoron@objectstack/spec, matching the precedent for extending this samecross-reference walk to a new surface (
nav-runaction-declared-contract.md, the #4848deep-link check).
Generated by Claude Code